Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: typo Update hardhat.md #1390

Merged
merged 1 commit into from
Dec 18, 2024
Merged

docs: typo Update hardhat.md #1390

merged 1 commit into from
Dec 18, 2024

Conversation

onasilos
Copy link
Contributor

This update addresses a minor inaccuracy in the Hardhat configuration documentation.

In the section detailing network configuration for Base, the comment for the Sepolia-based testnet was previously written as:

// for Sepolia testnet

This phrasing could cause confusion, as the context pertains to Base Sepolia, a testnet specific to the Base network built on Sepolia, rather than the Ethereum Sepolia testnet itself.

The comment has been updated to the following for improved clarity:

// for Base Sepolia testnet

This adjustment ensures that developers configuring their Hardhat projects understand that the testnet refers to Base's implementation and not the original Ethereum testnet.

Copy link

vercel bot commented Dec 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web-base-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 14, 2024 0:21am

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Dec 14, 2024

✅ Heimdall Review Status

Requirement Status More Info
Reviews 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

Copy link

vercel bot commented Dec 14, 2024

@onasilos is attempting to deploy a commit to the Coinbase Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

@wbnns wbnns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@onasilos Ty!

@wbnns wbnns enabled auto-merge (squash) December 18, 2024 13:30
@wbnns wbnns added community contribution base docs review To be reviewed by the Base docs team labels Dec 18, 2024
@wbnns wbnns merged commit 73267d0 into base:master Dec 18, 2024
4 of 6 checks passed
chrischang pushed a commit to chrischang/web that referenced this pull request Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
base docs review To be reviewed by the Base docs team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants